Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Coffea config from TOML file #648

Merged
merged 7 commits into from
Mar 16, 2022
Merged

Conversation

JayjeetAtGithub
Copy link
Contributor

No description provided.

@JayjeetAtGithub
Copy link
Contributor Author

@oshadura Here I have created a concept PR to create a global coffea config file which contains skyhook parameters. The coffea config file is located in the $HOME/.coffea.toml. We read this config file inside the Runner and read out skyhook config out of it. The user just needs to define use_skyhook=True now. Please let me know if this is in the right direction to make Coffea/Skyhook user-friendly.

@lgray
Copy link
Collaborator

lgray commented Mar 9, 2022

Please do not make this configuration information for skyhook a requirement for every single executor. That's a big change for our users.

@JayjeetAtGithub
Copy link
Contributor Author

JayjeetAtGithub commented Mar 9, 2022

@lgray Thanks a lot for looking into this. For the very same reason, I have kept the .coffea.toml file as optional. If there exists a .coffea.toml, then it will be read, otherwise it is not required. This config file currently serves only skyhook specific config, but serves as a placeholder to add other backend specific config in the future.

@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review March 13, 2022 20:28
@lgray
Copy link
Collaborator

lgray commented Mar 16, 2022

@JayjeetAtGithub are you done with this PR?

@JayjeetAtGithub
Copy link
Contributor Author

@lgray Yes, I am done

@lgray lgray merged commit a3ba69e into scikit-hep:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants